Add type stubs for P4 and P4API#11
Open
yangskyboxlabs wants to merge 1 commit intoperforce:masterfrom
Open
Conversation
This adds fairly comprehensive type annotations for P4API, and partially complete annotations for P4. P4.P4 is difficult to annotate more precisely as the run()-based functions have very loose argument semantics, and their outputs can very wildly based on input and internal state. Note that this addition does not currently support packaging. Python does not currently define a mechanism for indicating that a shared native library located outside of a package folder has type information.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fairly comprehensive type annotations for P4API, and partially complete annotations for P4.
P4.P4 is difficult to annotate more precisely as the run()-based functions have very loose argument semantics, and their outputs can very wildly based on input and internal state.
Note that this addition does not currently support packaging. Python does not currently define a mechanism for indicating that a shared native library located outside of a package folder has type information.
To actually ship this, AFAICT, p4python needs either:
P4APIis moved into a package so it can have stub annotation.p4python-stubspackage for stubs.